Skip to content

[UIK-4327][wizard] check sidebar recursively #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 23, 2025
Merged

[UIK-4327][wizard] check sidebar recursively #2519

merged 18 commits into from
Oct 23, 2025

Conversation

@ilyabrower
Copy link
Contributor

@ilyabrower ilyabrower commented Oct 10, 2025 •
edited by Valeria-Zimnitskaya
Loading

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new tests on added of fixed functionality.

@ilyabrower ilyabrower self-assigned this Oct 10, 2025
@ilyabrower ilyabrower force-pushed the UIK-4327/recursively-check-sidebar-in-wizard branch from 2a7b60e to 7975393 Compare October 16, 2025 14:00
Valeria-Zimnitskaya
Valeria-Zimnitskaya reviewed Oct 17, 2025
View reviewed changes
Valeria-Zimnitskaya
Valeria-Zimnitskaya reviewed Oct 17, 2025
View reviewed changes
j-mnizhek
j-mnizhek previously approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@j-mnizhek j-mnizhek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks fine! Left only one small comment for @Valeria-Zimnitskaya

j-mnizhek
j-mnizhek previously approved these changes Oct 23, 2025
View reviewed changes
@ilyabrower ilyabrower force-pushed the UIK-4327/recursively-check-sidebar-in-wizard branch from 46ca9a2 to 620c193 Compare October 23, 2025 11:18
@Valeria-Zimnitskaya Valeria-Zimnitskaya merged commit d1583e7 into release/v16 Oct 23, 2025
7 checks passed
@Valeria-Zimnitskaya Valeria-Zimnitskaya deleted the UIK-4327/recursively-check-sidebar-in-wizard branch October 23, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valeria-Zimnitskaya Valeria-Zimnitskaya Valeria-Zimnitskaya approved these changes

@j-mnizhek j-mnizhek j-mnizhek left review comments

@slizhevskyv-semrush slizhevskyv-semrush slizhevskyv-semrush left review comments

Assignees

@ilyabrower ilyabrower

Labels

wizard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ilyabrower @j-mnizhek @Valeria-Zimnitskaya @slizhevskyv-semrush